Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token-group: create editions example #5549

Closed
wants to merge 4 commits into from
Closed

token-group: create editions example #5549

wants to merge 4 commits into from

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Oct 16, 2023 •
edited
Loading

This PR adds another use case for the SPL Token Group example program: Editions!

It demonstrates using the interface to print "reprints" of an original token's metadata, using the Token Group interface to mark these reprints as part of the original group.

@buffalojoec buffalojoec mentioned this pull request Oct 16, 2023
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Oct 16, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@buffalojoec buffalojoec mentioned this pull request Oct 16, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch 4 times, most recently from 773d3a3 to e4e2745 Compare October 18, 2023 11:21
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_editions_example branch from 071627b to fb02abb Compare October 18, 2023 11:21
@buffalojoec buffalojoec marked this pull request as ready for review October 18, 2023 11:21
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from e4e2745 to d5a7a7f Compare October 18, 2023 11:56
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_editions_example branch from fb02abb to 5b80009 Compare October 18, 2023 12:05
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from d5a7a7f to 928093f Compare October 18, 2023 12:18
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_editions_example branch from 5b80009 to f22c516 Compare October 18, 2023 12:18
This was referenced Oct 18, 2023
Closed
Closed
Closed
@buffalojoec buffalojoec requested a review from joncinque October 18, 2023 13:11
@buffalojoec
Copy link
Contributor Author

@joncinque would love some thoughts on how to do this example while staying in step with discussions we're having here in this comment thread on #5548

@buffalojoec buffalojoec mentioned this pull request Oct 18, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from 928093f to c46f300 Compare October 18, 2023 21:19
@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_editions_example branch from f22c516 to a648ae3 Compare October 18, 2023 21:21
@buffalojoec
Copy link
Contributor Author

@joncinque would love some thoughts on how to do this example while staying in step with discussions we're having here in this comment thread on #5548

I guess as per that comment thread, it might make sense to remove this completely?

@joncinque
Copy link
Contributor

I was thinking it makes more sense as a totally separate reference implementation, at token-collection/program or token-edition/program. If it isn't too much annoyance. What do you think?

@buffalojoec
Copy link
Contributor Author

I was thinking it makes more sense as a totally separate reference implementation, at token-collection/program or token-edition/program. If it isn't too much annoyance. What do you think?

Yeah I'm up for that. They will be quite similar, though. I'll make those part of the stack :)

@buffalojoec buffalojoec force-pushed the 10-16-token-group_create_collections_example branch from c46f300 to 946b876 Compare October 19, 2023 11:56
@buffalojoec buffalojoec marked this pull request as draft October 19, 2023 14:39
@buffalojoec buffalojoec mentioned this pull request Oct 19, 2023
Merged
This was referenced Oct 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@buffalojoec buffalojoec deleted the 10-16-token-group_create_editions_example branch February 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque Awaiting requested review from joncinque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque