Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build v0.5.5 #835

Merged
merged 3 commits into from
Sep 14, 2023
Merged

fix: build v0.5.5 #835

merged 3 commits into from
Sep 14, 2023

Conversation

s-azumi
Copy link

@s-azumi s-azumi commented Sep 14, 2023

Description

humble環境でlanelet2_extension関連ノードのビルドが通るようにする修正をbeta/v0.5.5へ入れる

参考:

Tests performed

build-and-test-differentialが通ればOK

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Azumi Suzuki <[email protected]>
Signed-off-by: Azumi Suzuki <[email protected]>
Signed-off-by: Azumi Suzuki <[email protected]>
@s-azumi s-azumi marked this pull request as ready for review September 14, 2023 06:02
@s-azumi s-azumi requested a review from tkimura4 September 14, 2023 06:08
@s-azumi
Copy link
Author

s-azumi commented Sep 14, 2023

@tkimura4
beta/v0.5.5は今後あまり使う予定はありませんが、S1の現行バージョンのセットアップで詰まっていたメンバーが居たため修正させてください

Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 867207f into beta/v0.5.5 Sep 14, 2023
9 of 10 checks passed
@tkimura4 tkimura4 deleted the fix/build_v0.5.5 branch September 14, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants