feat(behavior_path_planner): add always executable module option (#4785) #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owarefoundation#4785) * feat(behavior_path_planner): add always executable module option Signed-off-by: kosuke55 <[email protected]> * fix conditions Signed-off-by: kosuke55 <[email protected]> * rename itr Signed-off-by: kosuke55 <[email protected]> * Update planning/behavior_path_planner/src/planner_manager.cpp Co-authored-by: Satoshi OTA <[email protected]> * Update planning/behavior_path_planner/src/planner_manager.cpp Co-authored-by: Satoshi OTA <[email protected]> * Update planning/behavior_path_planner/src/planner_manager.cpp Co-authored-by: Satoshi OTA <[email protected]> * fix candidate break Signed-off-by: kosuke55 <[email protected]> * Revert "fix candidate break" This reverts commit 0071bbd. * remove continue Signed-off-by: kosuke55 <[email protected]> * check manager_ptr->isAlwaysExecutableModule first Signed-off-by: kosuke55 <[email protected]> * common similar process Signed-off-by: kosuke55 <[email protected]> * fix getRequestModules Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: Satoshi OTA <[email protected]>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
tkimura4
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(behavior_path_planner): add always executable module option
fix conditions
rename itr
Update planning/behavior_path_planner/src/planner_manager.cpp
Update planning/behavior_path_planner/src/planner_manager.cpp
Update planning/behavior_path_planner/src/planner_manager.cpp
fix candidate break
Revert "fix candidate break"
This reverts commit 0071bbd.
remove continue
check manager_ptr->isAlwaysExecutableModule first
common similar process
fix getRequestModules
Description
cherry-pick autowarefoundation#4785
Tests performed
psim with this branch
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.