feat: range param for hesai

[yukkysaito]

PR Type

• New Feature

Related Links

Description

The XT-32 has been tested and confirmed to work on the actual device.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[drwnz]

LGTM!

[yukkysaito]

@drwnz @amc-nu I didn't pass one test, is that ok?

[amc-nu]

The tests fail because the new parameter is not set, and these default to 0 in the min and max parameters.

Can you please add these two new parameters to the tests?

https://github.com/tier4/nebula/blob/main/nebula_tests/hesai/hesai_ros_decoder_test.cpp#L90

[yukkysaito]

@amc-nu It has not passed the test yet. I need help. 🙏

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 11.54%. Comparing base (76526ca) to head (4a03713).

Files	Patch %	Lines
nebula_ros/src/hesai/hesai_decoder_ros_wrapper.cpp	0.00%	14 Missing ⚠️
nebula_tests/hesai/hesai_ros_decoder_test.cpp	40.00%	0 Missing and 9 partials ⚠️
...s/nebula_decoders_hesai/decoders/hesai_decoder.hpp	25.00%	0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            main     #121      +/-   ##
=========================================
+ Coverage   6.54%   11.54%   +4.99%     
=========================================
  Files        136       60      -76     
  Lines      10956     5623    -5333     
  Branches     859      814      -45     
=========================================
- Hits         717      649      -68     
+ Misses      9663     4410    -5253     
+ Partials     576      564      -12     

Flag	Coverage Δ
differential	11.54% <21.21%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amc-nu]

@yukkysaito Fixed in 4a03713