Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contribution guidelines #202

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Oct 1, 2024

PR Type

  • Improvement

Related Links

Description

Add contribution guidelines to Nebula. This allows easier contributions from the community and provides a clear set of rules and expectations we can refer to.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Oct 1, 2024
Copy link

sonarcloud bot commented Oct 1, 2024

@mojomex mojomex marked this pull request as ready for review October 3, 2024 07:26
@mojomex mojomex requested a review from drwnz October 3, 2024 07:26
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor (some more style-based that could go either way), with one or two must-fixes in there, but generally excellent.

docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
@mojomex
Copy link
Collaborator Author

mojomex commented Nov 11, 2024

@drwnz Thanks for the many suggestions! I applied them all. Please re-review when you find the time 🙏

@mojomex mojomex requested a review from drwnz November 11, 2024 06:10
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ;)

@mojomex mojomex merged commit 8740bb5 into tier4:main Nov 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants