-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add contribution guidelines #202
Conversation
Signed-off-by: Max SCHMELLER <[email protected]>
Quality Gate passedIssues Measures |
Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor (some more style-based that could go either way), with one or two must-fixes in there, but generally excellent.
…ssons continue Co-authored-by: David Wong <[email protected]>
@drwnz Thanks for the many suggestions! I applied them all. Please re-review when you find the time 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ;)
PR Type
Related Links
Description
Add contribution guidelines to Nebula. This allows easier contributions from the community and provides a clear set of rules and expectations we can refer to.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks