Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hesai): set PTP lock offset on sensor configuration #239

Merged
merged 10 commits into from
Dec 3, 2024
+110 −9

docs(hesai): describe effects of `ptp_lock_threshold` parameter

a52297a
Select commit
Loading
Failed to load commit list.
Merged

fix(hesai): set PTP lock offset on sensor configuration #239

docs(hesai): describe effects of `ptp_lock_threshold` parameter
a52297a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 3, 2024 in 1s

7.69% of diff hit (target 26.11%)

View this Pull Request on Codecov

7.69% of diff hit (target 26.11%)

Annotations

Check warning on line 704 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L704 

Added line #L704 was not covered by tests

Check warning on line 707 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L707 

Added line #L707 was not covered by tests

Check warning on line 711 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L709-L711 

Added lines #L709 - L711 were not covered by tests

Check warning on line 714 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L714 

Added line #L714 was not covered by tests

Check warning on line 716 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L716 

Added line #L716 was not covered by tests

Check warning on line 719 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L718-L719 

Added lines #L718 - L719 were not covered by tests

Check warning on line 1092 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L1092 

Added line #L1092 was not covered by tests

Check warning on line 1094 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L1094 

Added line #L1094 was not covered by tests

Check warning on line 1096 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L1096 

Added line #L1096 was not covered by tests

Check warning on line 1100 in nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp#L1100 

Added line #L1100 was not covered by tests

Check warning on line 178 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L177-L178 

Added lines #L177 - L178 were not covered by tests

Check warning on line 181 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L180-L181 

Added lines #L180 - L181 were not covered by tests

Check warning on line 196 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L195-L196 

Added lines #L195 - L196 were not covered by tests

Check warning on line 207 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L204-L207 

Added lines #L204 - L207 were not covered by tests
View more details on Codecov