Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ocaml version in https://github.com/tlaplus/tlapm/actions/workflows. #138

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

lemmy
Copy link
Member

@lemmy lemmy commented Jun 7, 2024

Do not run python to translate an opaque array index into a meaningful ocaml version number. Moreover, commit 5e71b24 revealed a problem with this; it introduced an out-of-bounds read.

[Build]

@lemmy lemmy added the enhancement A new feature, an improvement, or other addition. label Jun 7, 2024
.

Do not run python to translate an *opaque* array index into a meaningful ocaml version number. Moreover, commit 5e71b24 revealed a problem with this; it introduces an out-of-bounds read.

[Build]

Signed-off-by: Markus Alexander Kuppe <[email protected]>
@lemmy lemmy requested a review from kape1395 June 7, 2024 18:04
@lemmy lemmy marked this pull request as ready for review June 7, 2024 18:04
Copy link
Collaborator

@kape1395 kape1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to get rid of this mapping.

@kape1395 kape1395 merged commit 5718609 into main Jun 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature, an improvement, or other addition.
Development

Successfully merging this pull request may close these issues.

2 participants