Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Add Pagination #74583

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 7, 2025

This PR added style for pagination and has no logic difference.
Changed the filename from ErrorPagination to error-overlay-pagination for consistency.

Light

CleanShot 2025-01-07 at 21 37 29

Dark

CleanShot 2025-01-07 at 21 37 37

Closes NDX-576

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 7, 2025 12:42
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
buildDuration 18.1s 16.6s N/A
buildDurationCached 15.7s 13.5s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +49.9 kB
nextStartRea..uration (ms) 458ms 455ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B
Overall change 518 B 518 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 367 kB 367 kB ⚠️ +177 B
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 355 kB 355 kB ⚠️ +184 B
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB ⚠️ +361 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-07-_devoverlay_add_pagination Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +3.54 kB
index.pack gzip 76.3 kB 75.4 kB N/A
Overall change 2.09 MB 2.09 MB ⚠️ +3.54 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 811c02f

@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 3b50087 to c4d42c9 Compare January 7, 2025 15:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 063d7b2 to 0e17631 Compare January 7, 2025 15:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from c4d42c9 to a1642a2 Compare January 7, 2025 15:27
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 0e17631 to df8299c Compare January 7, 2025 15:27
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch 2 times, most recently from df8299c to c82735a Compare January 7, 2025 17:49
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 1876daa to ede9f89 Compare January 7, 2025 17:59
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from e28574a to 129d8f8 Compare January 7, 2025 17:59
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from ede9f89 to 3167e00 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 129d8f8 to a5b5ef3 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch 2 times, most recently from 4b76331 to ff112b2 Compare January 9, 2025 04:44
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from a5b5ef3 to 39c6d4b Compare January 9, 2025 04:44
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from ff112b2 to 6780089 Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 39c6d4b to af65367 Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 6780089 to 4dc12a6 Compare January 9, 2025 13:28
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 6bf0341 to b1a6981 Compare January 9, 2025 13:28
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from 4dc12a6 to 2b3d79b Compare January 10, 2025 06:55
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch 4 times, most recently from b937e58 to 18a3bff Compare January 10, 2025 08:52
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_floating_header branch from ecf84ac to f3d9971 Compare January 10, 2025 09:03
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 18a3bff to 05c3fa6 Compare January 10, 2025 09:03
@devjiwonchoi devjiwonchoi changed the base branch from 01-07-_devoverlay_add_floating_header to graphite-base/74583 January 10, 2025 11:51
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 05c3fa6 to e772f32 Compare January 10, 2025 11:54
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74583 to canary January 10, 2025 11:55
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from e772f32 to b83b1d5 Compare January 10, 2025 11:55
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 80bf6e1 to a2f5c51 Compare January 10, 2025 12:07
@devjiwonchoi devjiwonchoi merged commit ae431f2 into canary Jan 10, 2025
127 of 132 checks passed
Copy link
Member Author

Merge activity

  • Jan 10, 7:30 AM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 01-07-_devoverlay_add_pagination branch January 10, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants