-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevOverlay] Add Pagination #74583
Merged
Merged
[DevOverlay] Add Pagination #74583
+162
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2025
gaojude
approved these changes
Jan 7, 2025
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
buildDuration | 18.1s | 16.6s | N/A |
buildDurationCached | 15.7s | 13.5s | N/A |
nodeModulesSize | 416 MB | 416 MB | |
nextStartRea..uration (ms) | 458ms | 455ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
5306-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 241 B | 242 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 53 kB | 53 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
index.html gzip | 522 B | 521 B | N/A |
link.html gzip | 538 B | 535 B | N/A |
withRouter.html gzip | 518 B | 518 B | ✓ |
Overall change | 518 B | 518 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 207 kB | 207 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 668 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 367 kB | 367 kB | |
app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
app-page.run...dev.js gzip | 355 kB | 355 kB | |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.46 MB | 2.46 MB |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-07-_devoverlay_add_pagination | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.09 MB | |
index.pack gzip | 76.3 kB | 75.4 kB | N/A |
Overall change | 2.09 MB | 2.09 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 7, 2025 15:24
3b50087
to
c4d42c9
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 7, 2025 15:24
063d7b2
to
0e17631
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 7, 2025 15:27
c4d42c9
to
a1642a2
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 7, 2025 15:27
0e17631
to
df8299c
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
2 times, most recently
from
January 7, 2025 17:49
df8299c
to
c82735a
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 7, 2025 17:59
1876daa
to
ede9f89
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 7, 2025 17:59
e28574a
to
129d8f8
Compare
This was referenced Jan 7, 2025
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 8, 2025 14:00
ede9f89
to
3167e00
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 8, 2025 14:00
129d8f8
to
a5b5ef3
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
2 times, most recently
from
January 9, 2025 04:44
4b76331
to
ff112b2
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 9, 2025 04:44
a5b5ef3
to
39c6d4b
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 9, 2025 07:24
ff112b2
to
6780089
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 9, 2025 07:24
39c6d4b
to
af65367
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 9, 2025 13:28
6780089
to
4dc12a6
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 9, 2025 13:28
6bf0341
to
b1a6981
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 10, 2025 06:55
4dc12a6
to
2b3d79b
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
4 times, most recently
from
January 10, 2025 08:52
b937e58
to
18a3bff
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_floating_header
branch
from
January 10, 2025 09:03
ecf84ac
to
f3d9971
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 10, 2025 09:03
18a3bff
to
05c3fa6
Compare
eps1lon
approved these changes
Jan 10, 2025
...tal/internal/components/Errors/error-overlay-pagination/error-overlay-pagination.stories.tsx
Show resolved
Hide resolved
devjiwonchoi
changed the base branch from
01-07-_devoverlay_add_floating_header
to
graphite-base/74583
January 10, 2025 11:51
devjiwonchoi
force-pushed
the
graphite-base/74583
branch
from
January 10, 2025 11:54
f3d9971
to
67c3d7a
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 10, 2025 11:54
05c3fa6
to
e772f32
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 10, 2025 11:55
e772f32
to
b83b1d5
Compare
devjiwonchoi
force-pushed
the
01-07-_devoverlay_add_pagination
branch
from
January 10, 2025 12:07
80bf6e1
to
a2f5c51
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added style for pagination and has no logic difference.
Changed the filename from
ErrorPagination
toerror-overlay-pagination
for consistency.Light
Dark
Closes NDX-576