-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevOverlay] Apply Turbopack Styling #74636
Open
devjiwonchoi
wants to merge
7
commits into
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
Choose a base branch
from
01-08-_devoverlay_apply_turbopack_styling
base: 01-08-_devoverlay_decouple_dialog_component_from_error_overlay
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DevOverlay] Apply Turbopack Styling #74636
devjiwonchoi
wants to merge
7
commits into
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
from
01-08-_devoverlay_apply_turbopack_styling
+95
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 8, 2025 12:12
d462fc7
to
57352a9
Compare
devjiwonchoi
changed the base branch from
01-08-_devoverlay_polish_style_details_for_error_type_label_and_message
to
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
January 8, 2025 12:12
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
buildDuration | 22.6s | 20.2s | N/A |
buildDurationCached | 19.3s | 16.6s | N/A |
nodeModulesSize | 417 MB | 417 MB | |
nextStartRea..uration (ms) | 553ms | 547ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
5306-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 243 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 53 kB | 53 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
index.html gzip | 522 B | 521 B | N/A |
link.html gzip | 538 B | 535 B | N/A |
withRouter.html gzip | 518 B | 518 B | ✓ |
Overall change | 518 B | 518 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 207 kB | 207 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 672 B | 668 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 367 kB | 368 kB | |
app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
app-page.run...dev.js gzip | 355 kB | 356 kB | |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.46 MB | 2.46 MB |
build cache
vercel/next.js canary | vercel/next.js 01-08-_devoverlay_apply_turbopack_styling | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.09 MB | N/A |
index.pack gzip | 75.2 kB | 74.5 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 8, 2025 14:01
c132925
to
ed56af2
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 8, 2025 14:01
ba7c6ca
to
17a0c3b
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 9, 2025 04:46
ed56af2
to
f1d1fa4
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 9, 2025 04:47
17a0c3b
to
ff7bc1d
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 9, 2025 07:24
f1d1fa4
to
8f3be6e
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 9, 2025 07:24
ff7bc1d
to
8ca28ed
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 9, 2025 09:40
8f3be6e
to
eccabb2
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 9, 2025 09:40
8ca28ed
to
9c0f59f
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 06:56
cd1026d
to
7c3592c
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 08:13
18ec060
to
cada71a
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 08:13
7c3592c
to
3eed2c6
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 08:37
cada71a
to
25839a4
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 08:37
3eed2c6
to
1d49530
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 08:44
25839a4
to
b206513
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 08:44
1d49530
to
676404c
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 08:53
b206513
to
d2993f5
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 08:53
676404c
to
9656b7f
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 09:04
d2993f5
to
209241d
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 09:04
9656b7f
to
f53a05b
Compare
eps1lon
approved these changes
Jan 10, 2025
huozhi
reviewed
Jan 10, 2025
...ient/components/react-dev-overlay/_experimental/internal/components/Errors/dialog/header.tsx
Outdated
Show resolved
Hide resolved
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 11:56
209241d
to
d0813da
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 11:57
f53a05b
to
40ca927
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 12:08
d0813da
to
be27d0d
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 12:08
40ca927
to
ad48eba
Compare
huozhi
reviewed
Jan 10, 2025
...ient/components/react-dev-overlay/_experimental/internal/components/Errors/dialog/dialog.tsx
Outdated
Show resolved
Hide resolved
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 12:31
be27d0d
to
abc3bbe
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 12:32
669a4a0
to
10c4476
Compare
Co-authored-by: Jiachi Liu <[email protected]>
Co-authored-by: Jiachi Liu <[email protected]>
devjiwonchoi
force-pushed
the
01-08-_devoverlay_decouple_dialog_component_from_error_overlay
branch
from
January 10, 2025 13:11
abc3bbe
to
00bf4d8
Compare
devjiwonchoi
force-pushed
the
01-08-_devoverlay_apply_turbopack_styling
branch
from
January 10, 2025 13:11
10c4476
to
8eb0b85
Compare
huozhi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added Turbopack styling.
Light
Dark
Closes NDX-636