Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Apply Turbopack Styling #74636

Open
wants to merge 7 commits into
base: 01-08-_devoverlay_decouple_dialog_component_from_error_overlay
Choose a base branch
from

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 8, 2025

This PR added Turbopack styling.

Light

CleanShot 2025-01-08 at 22 55 43

Dark

CleanShot 2025-01-08 at 22 55 56

Closes NDX-636

@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from d462fc7 to 57352a9 Compare January 8, 2025 12:12
@devjiwonchoi devjiwonchoi changed the base branch from 01-08-_devoverlay_polish_style_details_for_error_type_label_and_message to 01-08-_devoverlay_decouple_dialog_component_from_error_overlay January 8, 2025 12:12
@ijjk
Copy link
Member

ijjk commented Jan 8, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 8, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
buildDuration 22.6s 20.2s N/A
buildDurationCached 19.3s 16.6s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +141 kB
nextStartRea..uration (ms) 553ms 547ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B
Overall change 518 B 518 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
middleware-b..fest.js gzip 672 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 367 kB 368 kB ⚠️ +913 B
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 355 kB 356 kB ⚠️ +913 B
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB ⚠️ +1.83 kB
build cache
vercel/next.js canary vercel/next.js 01-08-_devoverlay_apply_turbopack_styling Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.2 kB 74.5 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 8eb0b85

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 8, 2025 13:57
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from c132925 to ed56af2 Compare January 8, 2025 14:01
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from ba7c6ca to 17a0c3b Compare January 8, 2025 14:01
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from ed56af2 to f1d1fa4 Compare January 9, 2025 04:46
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 17a0c3b to ff7bc1d Compare January 9, 2025 04:47
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from f1d1fa4 to 8f3be6e Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from ff7bc1d to 8ca28ed Compare January 9, 2025 07:24
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from 8f3be6e to eccabb2 Compare January 9, 2025 09:40
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 8ca28ed to 9c0f59f Compare January 9, 2025 09:40
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from cd1026d to 7c3592c Compare January 10, 2025 06:56
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from 18ec060 to cada71a Compare January 10, 2025 08:13
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 7c3592c to 3eed2c6 Compare January 10, 2025 08:13
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from cada71a to 25839a4 Compare January 10, 2025 08:37
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 3eed2c6 to 1d49530 Compare January 10, 2025 08:37
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from 25839a4 to b206513 Compare January 10, 2025 08:44
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 1d49530 to 676404c Compare January 10, 2025 08:44
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from b206513 to d2993f5 Compare January 10, 2025 08:53
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 676404c to 9656b7f Compare January 10, 2025 08:53
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from d2993f5 to 209241d Compare January 10, 2025 09:04
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 9656b7f to f53a05b Compare January 10, 2025 09:04
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from 209241d to d0813da Compare January 10, 2025 11:56
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from f53a05b to 40ca927 Compare January 10, 2025 11:57
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from d0813da to be27d0d Compare January 10, 2025 12:08
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 40ca927 to ad48eba Compare January 10, 2025 12:08
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from be27d0d to abc3bbe Compare January 10, 2025 12:31
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 669a4a0 to 10c4476 Compare January 10, 2025 12:32
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_decouple_dialog_component_from_error_overlay branch from abc3bbe to 00bf4d8 Compare January 10, 2025 13:11
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_apply_turbopack_styling branch from 10c4476 to 8eb0b85 Compare January 10, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants