ci: Add cargo deny license check #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AiyionPrime
reviewed
Dec 2, 2024
There was a problem hiding this comment.
You might consider adding @julianoeltjen as co-author for f7be9f0, as he reviewed the licenses compatibilities.
philipp-caspers
force-pushed
the
ci/add-cargo-deny
branch
2 times, most recently
from
6c77c73 to
74ecda7
Compare
|
@julianoeltjen After a dependency update, the |
AiyionPrime
reviewed
Dec 2, 2024
Co-authored-by: Julian Oeltjen <[email protected]>
philipp-caspers
force-pushed
the
ci/add-cargo-deny
branch
from
74ecda7 to
1e8eefd
Compare
AiyionPrime
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
On a technical level this looks fine.
I'd suggest waiting for @julianoeltjen's approval to ensure he saw the license change, though.
julianoeltjen
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a cargo deny license check that verifies that every crate we use has license terms according to our expectations (defined in the
deny.toml).Closes PROG-4707.