Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): added alias as option in joinmeeting #3902

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

Parimala032
Copy link
Collaborator

@Parimala032 Parimala032 commented Oct 10, 2024

COMPLETES #SPARK-552246

This pull request addresses

This PR adds support for the alias parameter to the joinMeeting function and updates the corresponding unit tests to verify its correct handling.

by making the following changes

joinMeeting Function:
Added the text field in a samples page to enter the guest-user-name so the same name will be visible on the remote side as well and this text field name is an optional if user won't enter the name by default the system name will be taken

  • Included the alias parameter in the joinMeeting function call to ensure it is correctly passed along with other parameters.
    These changes are used for the user in such a way that when the user is trying to join the meeting by providing a name according to their wish it's going to be displayed on the remote side. so for this, we are adding one param as alias and passing it into the joinMeeting options

added an text field to enter the guest user name please do watch screen recording

added.textfeild.for.guest.user.name.mp4

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

Tested this flow by entering the name in a newly added text field, clicking on joinWithMedia button, and checked whether it's working or not by joining in the Meetings sample app it works fine as expected please see the screen recording for reference

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@Parimala032 Parimala032 requested a review from a team as a code owner October 10, 2024 10:21
@Parimala032 Parimala032 added the validated If the pull request is validated for automation. label Oct 10, 2024
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick comment and rest looks good.

However, can we add a text field in the Join meeting section of the sample app to get an alias name? If the box is empty, we need not send anything. This way, it'll be easily testable in future.

@Parimala032 Parimala032 requested a review from a team as a code owner October 14, 2024 16:22
@Parimala032
Copy link
Collaborator Author

Just a nitpick comment and rest looks good.

However, can we add a text field in the Join meeting section of the sample app to get an alias name? If the box is empty, we need not send anything. This way, it'll be easily testable in future.

Addressed your comments @mkesavan13

@sreenara sreenara merged commit afd2ae5 into webex:master Oct 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants