New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the /identity-providers/ API to manage user-defined federated authenticators. #735

Merged

Thisara-Welmilla merged 12 commits into wso2:master from Thisara-Welmilla:add-API-support-create-user-def-auth-fed

Dec 3, 2024

Contributor

Thisara-Welmilla commented Nov 7, 2024 •

edited

Loading

Issue:

Provide API for the new custom authentication management product-is#21216

This PR introduces improvements to the following APIs for managing user-defined federated authenticators:

/identity-providers: Updated the request body for the PUT request to accept both authenticator configuration models.
/identity-providers/{identity-provider-id}/federated-authenticators: Updated the request body for the PUT request to accept both authenticator configuration models.
/identity-providers/{identity-provider-id}/federated-authenticators/{federated-authenticator-id}: Updated the response and request bodies for both GET and PUT requests to accommodate both models.

Service layer PR:

Add support for managing custom federated authenticators. carbon-identity-framework#6105


          Update APIs to support custom authentication management.

a2fb35c

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 64340ab to a2fb35c Compare

November 7, 2024 16:43

Thisara-Welmilla marked this pull request as ready for review

November 11, 2024 03:19

This was referenced Nov 11, 2024

Add support for managing custom federated authenticators. wso2/carbon-identity-framework#6105

Merged

Provide API for the new custom authentication management wso2/product-is#21216

Open


          Update APIs to support custom authentication management.

cfc2832

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 05be0f7 to cfc2832 Compare

November 11, 2024 17:04


          Update APIs to support custom authentication management.

88ce34f

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 553c635 to 88ce34f Compare

November 12, 2024 04:54

Thisara-Welmilla changed the title ~~Update /identity-provider/ API to manage user defined federated authenticators.~~ Update the /identity-providers/ API to manage user-defined federated authenticators.

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Show resolved Hide resolved

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 2 times, most recently from 2d0d880 to 65d508c Compare

November 12, 2024 09:27


          Update APIs to support custom authentication management.

6d3a143

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 65d508c to 6d3a143 Compare

November 12, 2024 09:49

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...erver.idp.common/src/main/java/org/wso2/carbon/identity/api/server/idp/common/Constants.java Outdated Show resolved Hide resolved

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 7 times, most recently from 6500b42 to f8ad6fb Compare

November 13, 2024 12:37

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 5 times, most recently from 49d2d0a to f1c9ce8 Compare

November 15, 2024 12:00

malithie reviewed

View reviewed changes

.../wso2/carbon/identity/api/server/idp/v1/impl/FederatedAuthenticatorConfigBuilderFactory.java Show resolved Hide resolved


          Update APIs to support custom authentication management.

3da9303

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 2 times, most recently from 556500c to a0dad0a Compare

November 20, 2024 08:07

malithie previously approved these changes

View reviewed changes


          Update APIs to support custom authentication management.

455d408

Thisara-Welmilla dismissed malithie’s stale review via

455d408

November 23, 2024 16:43

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from a0dad0a to 455d408 Compare

November 23, 2024 16:43

Thisara-Welmilla added 2 commits

November 27, 2024 10:05


          Fix response for user defined auth.

b33ef9f


          Update APIs to support custom authentication management.

8e8632f

Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 1a9653a to 8e8632f Compare

November 28, 2024 10:48

This was referenced Dec 2, 2024

Add service layer support to manage the user defined local authenticators wso2/carbon-identity-framework#6071

Closed

Add DAO layer support to manage the user defined local authenticators wso2/carbon-identity-framework#6144

Closed

Thisara-Welmilla added 3 commits

December 2, 2024 18:06


          Update APIs to support custom authentication management.


          Merge branch 'master' into add-API-support-create-user-def-auth-fed

5e1c45c


          Bump carbon.identity.framework.version

32e899e

jenkins-is-staging commented Dec 3, 2024

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12139502796

malithie approved these changes

View reviewed changes

jenkins-is-staging commented Dec 3, 2024

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12139502796
Status: success

jenkins-is-staging approved these changes

View reviewed changes

jenkins-is-staging left a comment

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12139502796

Thisara-Welmilla merged commit 88432f4 into wso2:master

4 checks passed

This was referenced Dec 3, 2024

Fix not properly returning error messages and error descriptions for idp mgt #752

Merged

Improvement to the IdentityProviderManagementClientException class. wso2/carbon-identity-framework#6174

Merged

Fix not properly returning error messages and error discriptions for idp mgt wso2/product-is#21906

Closed

Improve error description for input validation fail #757

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet