Introduce Query Processor in v2 architecture #1119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
force-pushed
the
query-processor
branch
from
5a6e076 to
3d338fe
Compare
mieciu
force-pushed
the
query-processor
branch
2 times, most recently
from
2b4a0c0 to
fe02ebb
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
While working on #1119 I noticed that a lot of this code could already safely land in `main` branch and act as "general bridge" between the present and `v2` api. Notable changes are switching to interfaces (`LogManagerIface`/`QueryRunnerIFace`). Therefore we could introduce the intermediate layer in route handlers for queries which can use both old and new structures (new log manager using v2 api, etc.). Also, the `_field_caps` got more specific as it no longer accept full Quesma config to be more suited for being called within a processor (which just has index config).
mieciu
force-pushed
the
query-processor
branch
2 times, most recently
from
fdd248e to
ead8a1d
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
Mainly that's just adding 2 more methods to `LogManagerIFace` so that `terms_enum` request can be handled using `v2` api as well. Another round of "general changes" helpful for #1119
mieciu
force-pushed
the
query-processor
branch
from
ead8a1d to
44b3643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.