-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
models: De-duplicate and clean up #11009
Comments
Additionally: We have (Also, potentially we just move any generic models into |
On principle, I think it's completely fine to have a distinct models folder in each of those packages. The two packages have different purposes and audiences, so could plausibly have different model sets. However, in particular if you want to argue that box and box_small are stupid things to have in multibody/models, then that's a-ok by me to fix that acute problem.
This seems worse on all counts. |
FYI @IanTheEngineer |
I'm not clear on what's still to be done here. We already have more focused issues filed about Acrobot. Do we have other examples of duplication or required clean-ups? Or is the issue about seeking out any other similar problems, but we don't know of any yet? |
Ping @EricCousineau-TRI can we close this now? Or else can you clarify what's needed? |
Closing. #10531 is the other more general thing that needs fixing, but that's already tracked. The acrobot-specific bits are also tracked. Thanks for the ping! |
Relates #10531
We have some redundant models. I want to remove redundancy, and make things clearer (and possibly rely on upstream models when possible).
For example, @robert-verkuil ran into an issue where there are two Acrobot model files in the Drake source tree that he can't use from CMake (in
underactuated
):FindResourceOrThrow("drake/multibody/benchmarks/acrobot/acrobot.sdf")
indicates that this file is not installedFindResourceOrThrow("drake/examples/acrobot/Acrobot.sdf")
has an invalid spatial inertia for MBP's.EDIT: Gah!
Acrobot.sdf
isn't even used, aside from some randomattic
Python parsing tests!(Acute solution for this is to install
benchmarks/.../acrobot.sdf
for now.)The text was updated successfully, but these errors were encountered: