multibody: Install benchmarks models; deprecate redundant Acrobot models
#11011
Conversation
There was a problem hiding this comment.
+@RussTedrake for feature review for //examples; see #5408 + #10294 + #11009 for discussion.
(I want to consolidate these issues, but they all touch on different areas...)
\cc @jwnimmer-tri
Reviewable status: all discussions resolved, LGTM missing from assignee russtedrake, platform LGTM missing (waiting on @RussTedrake)
EricCousineau-TRI
changed the title
benchmarks modelsbenchmarks models; deprecate redundant Acrobot models
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee russtedrake, platform LGTM missing (waiting on @EricCousineau-TRI and @RussTedrake)
examples/acrobot/Acrobot.sdf, line 4 at r1 (raw file):
<sdf version='1.5'> <!-- DEPRECATED: This model will be removed on 2019-06-01. Please use `multibody/bencmarks/acrobot/acrobot.sdf instead. -->
nit bencmarks -> benchmarks (in several places)
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee russtedrake, platform LGTM missing (waiting on @EricCousineau-TRI and @RussTedrake)
a discussion (no related file):
Pending discussion in #5408 on how to de-duplicate code + data among //examples + //multibody/benchmarks:
#10294 (comment)
There was a problem hiding this comment.
this is one deletion, one deprecation message, and the addition of a lot of TODOs. fine for me.
Reviewed 14 of 14 files at r1.
Reviewable status: 2 unresolved discussions, platform LGTM from [russtedrake] (waiting on @EricCousineau-TRI)
|
Happy New Year, and thanks for your interest in contributing to Drake! Since this PR has not received any updates over the past 6+ months, we are closing it automatically. To resume the PR again, you may reopen it with updates, or open a new one. |
Towards #11009
Towards #5408 (in that we don't have to keep the
examplesfiles in sync if they don't exist)This change is