-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep Acrobot model files in sync #5408
Comments
The acrobot benchmark will probably prove useful in verifying the two different models. |
cc'ing @clalancette |
@RussTedrake cares a lot about what the examples look like. I suggest getting his explicit approval on any plan that touches examples/acrobot, before merging any PRs. |
Just answered in #10294 . There is downstream code that depends on these (in underactuated). |
@jwnimmer-tri I am not creating another acrobot in PR #13593. I think it important to be able to create small hand-crafted fixtures/models (e.g., a kinematic-only double pendulum) for testing purposes without reliance on other models that have other dependencies. To make this point clearer, I am adding the following comment to the test fixture (model): Note: As you deem best, feel free to unassign this issue to me. |
In https://github.com/RobotLocomotion/drake/tree/master/drake/examples/Acrobot, we have
Acrobot.sdf
andAcrobot.urdf
. The files should be interchangeable, so we should ensure that the two files remain sync'd, in terms of the resulting MultibodyTree and their dynamics.We had a program that performed this check at https://github.com/RobotLocomotion/drake/blob/e8ecbe96a6608b0ab61390b3dce06b6dc3fe4bfe/drake/multibody/rigid_body_system1/test/compareRigidBodySystems.cpp, but it got overtaken by events. We should consider reimplementing it, or else removing one of the two duplicated model files, or etc.
The text was updated successfully, but these errors were encountered: