-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drake website beta testing #14695
Comments
Are all the links supposed to be functional? |
Yup, everything should be finished, so anything that looks or operates wrong is unexpected. The link should point to |
There are quite a few explicit uses of Hopefully everyone is using something like HTTPS Everywhere. |
Comments will be due by March 3rd. I guess we'll pull the trigger and go live soon after that. |
In Is that intentional? Seems odd given that the links to the actual tarballs are below. |
That matches the current website: https://drake.mit.edu/from_binary.html I added it to the #13539 checklist as something to fix later on. |
So in our beta testing, should we only flag things that don't match the current website? |
I think its good to point out anything you don't like, but not all of the bugs will be blockers for switching over to the redesign. |
In Edit by Sean: More particularly, it should be |
In Same issue with the "platform reviewer’s responsibilities" link in |
In |
|
I think it's supposed to be a header (title) for the three boxes below it within that same gray region. Edit: To be clear, I'm not suggesting it's not a bug. Just for context. Edit 2: The https://drake.sky.a2hosted.com/ from the contractors didn't have this problem. Our rewrite / restyle of the index page appears to have broken this title position and spacing. |
Oh, NVM! It formatted so tidily I didn't realize I wasn't looking at the whole page (missed the skinny scrollbar). |
The link at Resources/For Developers/Issue Tracking/Platform Reviewer Checklists ( |
On Resources/Getting Help/Asking Your Questions/, we say "please email Russ Tedrake for access", shall we add Russ's email here? Edit (Jeremy): No. The intent is that only people who we already personally know (and thus who know Russ' email) will ask. |
The style is actually written so that we always see this. If you resize your window you'll see that the "core library" is always there on the bottom, even in significantly different viewport sizes. |
(arguably the tiny-font readability is impaired by oversaturation; https://ianstormtaylor.com/design-tip-never-use-black/ .) |
At the bottom of the front page (after scrolling all the way) there is a list of Acknowledgements with links. All of those work except the Office Of Naval Research link (currently |
Legacy issue in
It seems when the weekly CI info was inserted (6ecb9bb), the weekly info was squeezed before "nightly" and "run at most once per day". Edit (Jeremy): I don't see the problem? It is correct that the weekly builds are resource intensive, and that they are run at most once per day. |
python_bindings page, "using the python bindings", the link under "Python API" has weird trailing giblets Edit (Jeremy): In the Sphinx page that contained the hyperlink, they were actually required. We can drop them from Jekyll now, though. |
website_licenses.html Two of the linked documents (for the github mark and for python) are markdown but are rendered as text. Edit (Jeremy): Working as intended. |
In
|
In
|
older_releases page is the only one with a leading "Back to ..." link. This is ideosyncratic, especially as it is linked from other places than its backto parent. Edit (Jeremy): All of the release notes pages (0.27, etc.) have this back-link. |
in
|
in
|
In
|
On The link to |
In
|
A passing note inspired by Given a fixed-width browser, on the whole the pages have been readable. In this case, because of:
Much of the text is no longer available and requires me to scroll individual windows. Sad. :( |
We should probably also test the site with javascript disabled? |
Is anyone testing with a mobile device profile (or even better an actual mobile device)? |
I've viewed a few pages with chrome dev tools' mobile renderer; they are neither especially good nor especially bad. If we really care about mobile users we should follow the lighthouse recommendations linked above (mobile readability being especially contrast sensitive, for example, because of glare) rather than mostly ignore them as I had suggested. However debugging mobile presentation will be a lot easier once we're serving the pages; Drake isn't exactly useful from mobile, so I would propose deferring any serious mobile optimization until after the new site is up on |
Certainly, though the Google indexer is mobile first now. |
The remaining open items have been moved into #14757. |
As the final step of #13832, we're going to ask a few people to beta test the website redesign.
Preview instructions are given at https://drake.mit.edu/documentation_instructions.html. Remember to pull the latest master branch first, and note that you need to run
install_prereqs
with extra flags first per the top of that page, and then jump down to the Jekyll section.Testers are welcome to open a PR with changes they'd like to suggest, and we can merge those at any point.
Alternatively, problems that people identify which they can't or won't themselves should be posted as independent comments in this issue. We'll come by later and turn any required fixes based on those comments into a checklist in the top post here.
Testing & comments are due by 2021-03-03.
The problems which remain unfixed are:
The text was updated successfully, but these errors were encountered: