-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworking Drake's website #13832
Comments
Updates:
For reference, docs.bazel.build also uses Jekyll via Dockerfile; their code is at https://github.com/bazelbuild/bazel/tree/master/scripts/docs. Drake's python styleguide also uses Jekyll (since it's based on the Google guide which does so), our preview tool for that is https://github.com/RobotLocomotion/styleguide/blob/gh-pages/preview_site_jekyll.py. I guess I will see how easy or hard adding Jekyll to our Drake docs pipeline looks like. An easy local preview is mostly likely the only real challenge. FYI the
|
My proposal in a quick chat with @jamiesnape today (and afterwards elaborated) was: (1) demote the website out of (2) switch the default sense of (3) add Ruby and Jekyll as a docs-only dependency on all platforms; on Ubuntu, we should try very hard to use the stock apt version of Jekyll, even if it means losing the sitemap for now; (4) create a (shadow, non-hyperlinked) page or two in parallel with the live site to stand up the tools and deploy pipeline; (5) migrate the current content to Jekyll by transmogrifying rst to md using the current prose and contractor's stylesheet; (6) incorporate the additional page flow and copy editing changes from the contractors. |
|
Yes, I figured we would remove the sitemap entirely until we can change the Documentation builds to Focal. |
@jamiesnape I'm going to put (1..4) above on the To Do board at https://github.com/RobotLocomotion/drake/projects/2 for your queue. |
Related to (1) -- would be good to keep |
Update on (3) -- my new advice is to drop macOS from the platforms we support for local documentation preview. There are very few contributors who do not have access to Ubuntu. For Doxygen, Jekyll, and Sphinx, we should only support Ubuntu from now on. |
From #14168 review: it seems like |
LGTM |
Update on checklist, as I understand it now:
|
As I understand it, now that #14531 + RobotLocomotion/drake-ci#119 have merged, we have a live pipeline where is published as (You can "view source" on the blank page to prove the page is not totally empty.) |
Update is nightly, but otherwise yes. |
Updated above bullet-points to add in point (5.2), with more info in #14575 |
As part of the website transition, for a period of time (once #14612 lands tomorrow) we’re going to have two copies of the website on master (in rst format, and md format). PRs that change the text of the docs will have to keep both in sync. |
@ToffeeAlbina-TRI / Jeremy: Who's on point for Python doc Sphinx |
Not sure exactly what you're asking about. Is it about resurrecting #13983 sans the style-licensing snafu? My vote would be give up on that and leave the https://drake.mit.edu/pydrake/ style unchanged. To resurrect it, we'd probably want to go back to the contractors to revise the style without including derivative content, but it was such a bear to try to get our patches and macOS unicode font support and etc fixed up the first time, because the contractors don't use change control, that the bang-for-the-buck there doesn't seem worth it to me. In any case, I'm not currently planning on working on it. |
SGTM. |
#13983 would need deconstructing and reconstructing, which is tedious, time consuming, and expensive, and once you have done that you might finally be able to see where the code came from and have to dump it anyway. Same problem as the main site. |
BTW The current theme (RTD) was completely arbitrarily chosen by me, so maybe just find an FOSS one that you like, does not clash too badly, and conveys all the information as best as possible. |
Yes, that's a good point. If we want to improve pydrake API style, a Drake Developer could just start a new project to find a FOSS style they like better, and get that PR'd. That's more sensible that trying to rework the prior attempt. It's a project management question (@ToffeeAlbina-TRI) whether we task anyone to do that, and on what timeframe. |
FYI Here's my command-line to compare the inventory of the two websites, useful for finding pages that are missing or mis-named:
|
The main work is done. Future improvements are tracked in #14757. |
We'd like to rework some of the content and style of https://drake.mit.edu/. As part of this work, we'll probably need to tweak our workflow for hosting some static assets. This is a tracking issue to explore that topic.
The text was updated successfully, but these errors were encountered: