-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_version_control.md
is out of date; local repositories don't work
#19822
Comments
The other work-around is to avoid |
Good to know that would work. I already considered that step 2, and could use that for now. |
I think something like this would disable the checksum validation, to at least slightly smooth out that workflow: --- a/tools/workspace/github.bzl
+++ b/tools/workspace/github.bzl
@@ -298,10 +298,7 @@ def _sha256(sha256):
Args:
sha256: expected SHA-256 hash of the archive to be downloaded.
"""
- if not sha256:
- sha256 = "0" * 64
-
- return sha256
+ return None
def _strip_prefix(repository, commit, extra_strip_prefix):
"""Compute the strip prefix for a downloaded archive of the provided |
Reducing priority, since the work-around mean it is not an immediate blocker. |
Related: Looks like I must have missed a step in #19771; building the python bindings now warns about
But I can't see what step I might have missed... I will update the issue title with the real victory condition: an updated |
drake_repository_metadata.json
for RobotLocomotion/models
model_version_control.md
is out of date; local repositories don't work and new install artifacts are marked as "foreign"
Follow-up to RobotLocomotion#19771. Related to RobotLocomotion#19822. The workflow for drake_models has changed. I should not have installed them.
model_version_control.md
is out of date; local repositories don't work and new install artifacts are marked as "foreign"model_version_control.md
is out of date; local repositories don't work
What happened?
I'm trying to add models to Robotlocomotion/models following the instructions in
model_version_control.md
, but I think perhaps the steps have changed? Simply using local_repository_overload gives me the error:@jwnimmer-tri confirmed that "It's generated from
tools/workspace/github.bzl
. I'll need to do a real fix, but for now I think you could try remove the data citation inBUILD
, and nerfGetDrakeModelsRemoteParams()
in the code to return a default-constructed object instead of using the json.Version
No response
What operating system are you using?
No response
What installation option are you using?
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: