Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic): add SymbolTable::symbol_is_mutated method #7755

Merged
merged 1 commit into from
Dec 10, 2024
Merged

feat(semantic): add SymbolTable::symbol_is_mutated method #7755

merged 1 commit into from
Dec 10, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 9, 2024 •
edited
Loading

Add SymbolTable::symbol_is_mutated method. Returns true if the symbol is not a const and has any references with ReferenceFlags::Write.

@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Dec 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 9, 2024
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Dec 9, 2024
This was referenced Dec 9, 2024
Merged
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7755 will not alter performance

Comparing 12-09-feat_semantic_add_symboltable_symbol_is_mutated_method (78dff7d) with main (3c1b2bf)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 22:03
@overlookmotel overlookmotel mentioned this pull request Dec 10, 2024
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 10, 2024 •
edited
Loading

Merge activity

@overlookmotel
feat(semantic): add SymbolTable::symbol_is_mutated method (#7755)
78dff7d 
Add `SymbolTable::symbol_is_mutated` method. Returns `true` if the symbol is not a `const` and has any references with `ReferenceFlags::Write`.
@Dunqing Dunqing force-pushed the 12-09-refactor_transformer_introduce_transformctx_duplicate_expression_ branch from b23adea to b500f55 Compare December 10, 2024 02:28
@Dunqing Dunqing force-pushed the 12-09-feat_semantic_add_symboltable_symbol_is_mutated_method branch from 99542f4 to 78dff7d Compare December 10, 2024 02:29
Base automatically changed from 12-09-refactor_transformer_introduce_transformctx_duplicate_expression_ to main December 10, 2024 02:34
@graphite-app graphite-app bot merged commit 78dff7d into main Dec 10, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 12-09-feat_semantic_add_symboltable_symbol_is_mutated_method branch December 10, 2024 02:45
@oxc-bot oxc-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen Boshen is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel