feat(transformer/logical-assignment-operators): no temp vars for literals #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2024
This was referenced Dec 9, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
overlookmotel
force-pushed
the
12-09-test_transformer_enable_fixture_overrides_for_logical-assignment-operators_transform
branch
from
6bd6f96 to
b7ffc3e
Compare
overlookmotel
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
22c18fe to
44c3254
Compare
CodSpeed Performance ReportMerging #7759 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
44c3254 to
71ed650
Compare
Merge activity
|
…rals (#7759) `TransformCtx::duplicate_expression` (introduced in #7754) don't create temp vars for literals. This produces more compact output for the logical assignment operators transform. This diverges from Babel (it's better!) so add an override for one of Babel's fixtures. Also add further tests for all literal types.
Dunqing
force-pushed
the
12-09-test_transformer_enable_fixture_overrides_for_logical-assignment-operators_transform
branch
from
b7ffc3e to
8f8b4c3
Compare
Dunqing
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
71ed650 to
e010b6a
Compare
Base automatically changed from
12-09-test_transformer_enable_fixture_overrides_for_logical-assignment-operators_transform
to
main
December 10, 2024 03:03
graphite-app
bot
deleted the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformCtx::duplicate_expression(introduced in #7754) don't create temp vars for literals. This produces more compact output for the logical assignment operators transform.This diverges from Babel (it's better!) so add an override for one of Babel's fixtures. Also add further tests for all literal types.