-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(traverse)!: remove TraverseCtx::is_static
#7760
Merged
graphite-app
merged 1 commit into
main
from
12-09-refactor_traverse_remove_traversectx_is_static_
Dec 10, 2024
Merged
refactor(traverse)!: remove TraverseCtx::is_static
#7760
graphite-app
merged 1 commit into
main
from
12-09-refactor_traverse_remove_traversectx_is_static_
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2024
github-actions
bot
added
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
A-transformer
Area - Transformer / Transpiler
labels
Dec 9, 2024
overlookmotel
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
December 9, 2024 21:54
22c18fe
to
44c3254
Compare
overlookmotel
force-pushed
the
12-09-refactor_traverse_remove_traversectx_is_static_
branch
from
December 9, 2024 21:55
e5517f4
to
1d1c902
Compare
CodSpeed Performance ReportMerging #7760 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
overlookmotel
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
December 9, 2024 22:34
44c3254
to
71ed650
Compare
overlookmotel
force-pushed
the
12-09-refactor_traverse_remove_traversectx_is_static_
branch
from
December 9, 2024 22:34
1d1c902
to
2bcaebc
Compare
Merge activity
|
`TraverseCtx::is_static` was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method. `TransformCtx::duplicate_expression` fulfills the same role.
Dunqing
force-pushed
the
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
branch
from
December 10, 2024 02:32
71ed650
to
e010b6a
Compare
Dunqing
force-pushed
the
12-09-refactor_traverse_remove_traversectx_is_static_
branch
from
December 10, 2024 02:32
2bcaebc
to
5d6fa25
Compare
Base automatically changed from
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
to
main
December 10, 2024 03:06
graphite-app
bot
deleted the
12-09-refactor_traverse_remove_traversectx_is_static_
branch
December 10, 2024 03:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraverseCtx::is_static
was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method.TransformCtx::duplicate_expression
fulfills the same role.