Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token 2022: add UpdateGroupMaxSize instruction from SPL Token Group interface #5626

Merged
merged 2 commits into from
Nov 15, 2023
Merged

token 2022: add UpdateGroupMaxSize instruction from SPL Token Group interface #5626

merged 2 commits into from
Nov 15, 2023

Conversation

buffalojoec
Copy link
Contributor

This PR adds the UpdateGroupMaxSize instruction to Token2022 - from the SPL Token Group interface.

This was referenced Oct 21, 2023
Merged
Merged
Closed
Merged
Merged
Closed
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Oct 21, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Oct 21, 2023
Merged
Merged
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 8080c30 to 17677bf Compare October 21, 2023 14:55
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from f89116d to 0b2bfa8 Compare October 21, 2023 14:55
This was referenced Oct 22, 2023
Merged
Merged
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 17677bf to 6b67ebc Compare October 23, 2023 12:35
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 0b2bfa8 to 57c6b07 Compare October 23, 2023 12:35
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 6b67ebc to aa4c6d4 Compare October 24, 2023 10:39
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 57c6b07 to 2194647 Compare October 24, 2023 10:39
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from aa4c6d4 to 01f924d Compare October 26, 2023 14:25
@buffalojoec buffalojoec mentioned this pull request Oct 26, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch 3 times, most recently from 837a1a0 to b31b5d0 Compare October 26, 2023 15:23
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from b31b5d0 to 629e2c2 Compare November 6, 2023 20:57
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 2194647 to 4f893c0 Compare November 6, 2023 20:58
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch 2 times, most recently from e7fb59c to 3a0de2e Compare November 9, 2023 09:13
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 4f893c0 to a0fc789 Compare November 9, 2023 09:13
Base automatically changed from 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface to master November 9, 2023 13:01
@joncinque
Copy link
Contributor

Once these PRs are rebased, I'll take a look!

@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from a0fc789 to 21d7820 Compare November 9, 2023 14:31
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 21d7820 to 2165e66 Compare November 10, 2023 13:33
@buffalojoec buffalojoec added the do-not-close Add this tag to exempt a PR / issue from being closed automatically label Nov 12, 2023
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch from 2165e66 to 221ce2d Compare November 14, 2023 14:36
This was referenced Nov 14, 2023
Closed
Closed
Closed
Closed
joncinque
joncinque previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment about the test, then this is good to go!

large-small

token/program-2022-test/tests/token_group_update_max_size.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed joncinque’s stale review November 15, 2023 13:30

Pull request has been modified.

@buffalojoec buffalojoec merged commit 3ab6e24 into master Nov 15, 2023
34 checks passed
@buffalojoec buffalojoec deleted the 10-18-token_2022_add_UpdateGroupMaxSize_instruction_from_SPL_Token_Group_interface branch November 15, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
do-not-close Add this tag to exempt a PR / issue from being closed automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque