Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token 2022: add GroupMemberPointer extension #5628

Merged
merged 3 commits into from
Nov 28, 2023
Merged

token 2022: add GroupMemberPointer extension #5628

merged 3 commits into from
Nov 28, 2023

Conversation

buffalojoec
Copy link
Contributor

This PR adds the GroupMemberPointer extension to Token2022.

This extension behaves exactly like the existing GroupPointer extension, serving to denote the corresponding account containing a mint's group member configurations and prevent any unauthorized configurations.

This was referenced Oct 22, 2023
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Oct 22, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Oct 22, 2023
Merged
Merged
@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch from c28bc25 to e52e102 Compare October 22, 2023 12:25
@buffalojoec buffalojoec marked this pull request as draft October 23, 2023 12:06
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface branch 3 times, most recently from 6a54e00 to 818d2b5 Compare October 24, 2023 10:40
@buffalojoec buffalojoec mentioned this pull request Oct 26, 2023
Merged
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface branch 4 times, most recently from bf04d1b to 65ac100 Compare November 10, 2023 13:34
@buffalojoec buffalojoec added the do-not-close Add this tag to exempt a PR / issue from being closed automatically label Nov 12, 2023
@buffalojoec buffalojoec force-pushed the 10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface branch from 65ac100 to 3cf8ea8 Compare November 14, 2023 14:36
@buffalojoec buffalojoec mentioned this pull request Nov 14, 2023
Closed
@buffalojoec buffalojoec changed the base branch from 10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface to 11-14-token_2022_add_support_for_additional_signers_in_test_init_functions November 14, 2023 14:36
@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch from e52e102 to 5f3942d Compare November 14, 2023 14:36
This was referenced Nov 14, 2023
Closed
Closed
Closed
@buffalojoec buffalojoec force-pushed the 11-14-token_2022_add_support_for_additional_signers_in_test_init_functions branch from 65c5fbd to 6320eb8 Compare November 16, 2023 21:03
@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch 2 times, most recently from bbd4c02 to c9ec232 Compare November 16, 2023 21:47
buffalojoec
buffalojoec commented Nov 16, 2023
View reviewed changes
Copy link
Contributor Author

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @joncinque this should be ready for another look. Thanks for the previous review! RIP to repeating extensions 🪦

token/program-2022/src/extension/group_pointer/processor.rs Show resolved Hide resolved
@buffalojoec buffalojoec marked this pull request as ready for review November 16, 2023 22:12
joncinque
joncinque reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few repeated comments, mostly on the interface and structs. Once we agree there, I'll take a closer look at the implementation and test

token/program-2022/src/extension/group_member_pointer/mod.rs Outdated Show resolved Hide resolved
token/program-2022/src/extension/group_member_pointer/mod.rs Outdated Show resolved Hide resolved
token/program-2022/src/extension/group_member_pointer/instruction.rs Outdated Show resolved Hide resolved
token/program-2022/src/extension/group_member_pointer/instruction.rs Outdated Show resolved Hide resolved
token/program-2022/src/extension/group_member_pointer/processor.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
@buffalojoec
Copy link
Contributor Author

@joncinque considering the discussion here I'm going to re-work this PR and remove the group auth stuff.

@buffalojoec
Copy link
Contributor Author

Done. Note I deleted the prior branch in the stack, so I re-wrote the commit here.

@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch from 24cb26a to d674818 Compare November 20, 2023 13:29
@buffalojoec buffalojoec changed the base branch from 11-14-token_2022_add_support_for_additional_signers_in_test_init_functions to master November 20, 2023 13:29
@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch 3 times, most recently from cb4de48 to 106a697 Compare November 21, 2023 10:52
joncinque
joncinque reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base logic looks good! Just one point on the code, and then a few places to simplify the tests

token/program-2022/src/extension/group_member_pointer/mod.rs Show resolved Hide resolved
token/program-2022/src/extension/group_member_pointer/processor.rs Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
token/program-2022-test/tests/group_member_pointer.rs Outdated Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the 10-22-token_2022_add_GroupMemberPointer_extension branch from 106a697 to fbcb302 Compare November 28, 2023 01:07
joncinque
joncinque approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

member

@buffalojoec buffalojoec merged commit 0df0cba into master Nov 28, 2023
34 checks passed
@buffalojoec buffalojoec deleted the 10-22-token_2022_add_GroupMemberPointer_extension branch November 28, 2023 15:44
@buffalojoec buffalojoec mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
do-not-close Add this tag to exempt a PR / issue from being closed automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque