token 2022: add new offchain helper #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
01-09-token_2022_add_new_offchain_helper
branch
2 times, most recently
from
9f760e1 to
0c3b21e
Compare
joncinque
approved these changes
Jan 10, 2024
buffalojoec
force-pushed
the
01-09-token_2022_add_new_offchain_helper
branch
2 times, most recently
from
95bbbbd to
2fa3ac2
Compare
This was referenced Jan 10, 2024
joncinque
previously approved these changes
Jan 10, 2024
buffalojoec
force-pushed
the
01-09-transfer_hook_add_new_offchain_helper
branch
from
262663a to
3700ef4
Compare
buffalojoec
force-pushed
the
01-09-token_2022_add_new_offchain_helper
branch
from
2fa3ac2 to
8c04474
Compare
Merge activity
|
Base automatically changed from
01-09-transfer_hook_add_new_offchain_helper
to
master
January 11, 2024 21:15
buffalojoec
force-pushed
the
01-09-token_2022_add_new_offchain_helper
branch
from
8c04474 to
006e8fc
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
buffalojoec
pushed a commit
that referenced
this pull request
Jan 11, 2024
Following up from the new helpers added in #6099 and #6100, there's a transfer hook test in `program-2022-test` that's using the now-deprecated helper to build a swap instruction for the test program. This PR replaces that bit of code to use the new helper from `spl_transfer_hook_interface`. Note: The test in question is designed to test Token2022's `invoke_transfer_checked(..)` on-chain helper, *not* the offchain helpers. So, it's appropriate to use the offchain helper directly from the interface crate for this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new offchain helper for creating a
TransferCheckedinstructionwith the necessary accounts metas for a transfer hook
ExecuteInstructiontoToken2022, deprecating the old one.
As described in #6064, the original offchain helper in Token2022 was being used
incorrectly to resolve extra account metas. Rather than providing the SPL
Transfer Hook interface helper with a valid
ExecuteInstruction, the originalToken2022 helper was actually providing it with a transfer instruction, causing
erroneous account resolution.
Taking advantage of the more secure SPL Transfer Hook interface offchain helper
provided in #6099, this new offchain helper creates a
TransferCheckedinstruction and calls
add_extra_account_metas_for_execute(..), providing thekeys used to build the transfer instruction.
Note: unlike the deprecated helper in #6099, the deprecated offchain helper in
Token2022 is in fact inaccurately resolving account metas for certain use
cases, thus it should be vigilantly avoided.