Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token 2022 test: refactor transfer hook test to use new offchain helper #6110

Conversation

buffalojoec
Copy link
Contributor

Following up from the new helpers added in #6099 and #6100, there's a transfer
hook test in program-2022-test that's using the now-deprecated helper to build
a swap instruction for the test program.

This PR replaces that bit of code to use the new helper from
spl_transfer_hook_interface.

Note: The test in question is designed to test Token2022's
invoke_transfer_checked(..) on-chain helper, not the offchain helpers. So,
it's appropriate to use the offchain helper directly from the interface crate
for this step.

joncinque
joncinque previously approved these changes Jan 10, 2024
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper branch from 7de4df7 to 0b076b1 Compare January 10, 2024 22:04
@buffalojoec buffalojoec requested a review from joncinque January 10, 2024 22:04
@buffalojoec buffalojoec force-pushed the 01-10-token_client_refactor_transfer_to_use_new_offchain_helper branch from 37daf18 to 1358800 Compare January 11, 2024 16:36
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper branch from 0b076b1 to 269ff6f Compare January 11, 2024 16:36
Copy link
Contributor Author

buffalojoec commented Jan 11, 2024

Merge activity

  • Jan 11, 4:15 PM: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Jan 11, 4:19 PM: Graphite rebased this pull request as part of a merge.
  • Jan 11, 4:20 PM: @buffalojoec merged this pull request with Graphite.

@buffalojoec buffalojoec force-pushed the 01-10-token_client_refactor_transfer_to_use_new_offchain_helper branch from 1358800 to e2efa93 Compare January 11, 2024 21:16
Base automatically changed from 01-10-token_client_refactor_transfer_to_use_new_offchain_helper to master January 11, 2024 21:18
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper branch from 269ff6f to 63e8f91 Compare January 11, 2024 21:18
@mergify mergify bot dismissed joncinque’s stale review January 11, 2024 21:19

Pull request has been modified.

@buffalojoec buffalojoec merged commit 5f490e5 into master Jan 11, 2024
29 checks passed
@buffalojoec buffalojoec deleted the 01-10-token_2022_test_refactor_transfer_hook_test_to_use_new_offchain_helper branch January 11, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants