token client: refactor transfer to use new offchain helper

[buffalojoec]

This PR continues the necessary repairs for addressing #6064 by refactoring the
Token Client's transfer(..) function to use the new offchain transfer hook
helpers.

If transfer hook accounts are provided, in either case they're appended to the
instruction like before.

If no transfer hook accounts are provided:

• If decimals are provided, Token2022's offchain helper
  create_transfer_checked_instruction_with_extra_metas(..) is used.
• If decimals are not provided, SPL Transfer Hook interface's
  add_extra_account_metas_for_execute(..) is used.

In either case where no transfer hook accounts are provided, the new,
non-deprecated helpers are used.

[buffalojoec]

Current dependencies on/for this PR:

• master
  • PR transfer hook: add new offchain helper #6099
    • PR token 2022: add new offchain helper #6100
      • PR token client: refactor transfer to use new offchain helper #6107 👈
        • PR token 2022 test: refactor transfer hook test to use new offchain helper #6110
          • PR transfer hook: add new onchain helper #6111
            • PR token 2022: repair onchain helper #6112
              • PR token js: create new offchain helper #6108

This stack of pull requests is managed by Graphite.

[joncinque]

I might have misunderstood the unchecked portion, but after that, this looks good!

[buffalojoec]

Merge activity

• Jan 11, 4:15 PM: @buffalojoec started a stack merge that includes this pull request via Graphite.
• Jan 11, 4:17 PM: Graphite rebased this pull request as part of a merge.
• Jan 11, 4:18 PM: @buffalojoec merged this pull request with Graphite.

Pull request has been modified.