Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token 2022: repair onchain helper #6112

Merged
merged 1 commit into from
Jan 11, 2024
Merged

token 2022: repair onchain helper #6112

merged 1 commit into from
Jan 11, 2024

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Jan 10, 2024 •
edited
Loading

Continuing on from the new helper introduced in #6111.

Here the onchain helper in Token2022 is updated to use the non-deprecated new
onchain helper from SPL Transfer Hook interface.

PDAs as extra meta configs are also added to the transfer hook test in
program-2022-test for additional assurance.

@buffalojoec buffalojoec requested a review from joncinque January 10, 2024 22:04
This was referenced Jan 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Jan 10, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@buffalojoec buffalojoec force-pushed the 01-10-transfer_hook_add_new_onchain_helper branch 2 times, most recently from 1b717ce to dfb7feb Compare January 10, 2024 23:25
joncinque
joncinque approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some extra changes from the previous PR snuck in here, but otherwise looks great!

token/transfer-hook/interface/src/onchain.rs Outdated Show resolved Hide resolved
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_repair_onchain_helper branch 2 times, most recently from b47b84e to a7e399c Compare January 11, 2024 01:02
@buffalojoec
Copy link
Contributor Author

FYI, this looks a tad different now that we're passing AccountInfo.

joncinque
joncinque previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good!

@buffalojoec buffalojoec force-pushed the 01-10-transfer_hook_add_new_onchain_helper branch from e6238ed to b1c626e Compare January 11, 2024 16:37
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_repair_onchain_helper branch from a7e399c to ed3fca4 Compare January 11, 2024 16:38
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Jan 11, 2024 •
edited
Loading

Merge activity

  • Jan 11, 4:15 PM: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Jan 11, 4:23 PM: Graphite rebased this pull request as part of a merge.
  • Jan 11, 4:24 PM: @buffalojoec merged this pull request with Graphite.

@buffalojoec buffalojoec force-pushed the 01-10-transfer_hook_add_new_onchain_helper branch from b1c626e to 667b867 Compare January 11, 2024 21:20
Base automatically changed from 01-10-transfer_hook_add_new_onchain_helper to master January 11, 2024 21:22
@buffalojoec buffalojoec force-pushed the 01-10-token_2022_repair_onchain_helper branch from ed3fca4 to 367eedb Compare January 11, 2024 21:22
@mergify mergify bot dismissed joncinque’s stale review January 11, 2024 21:23

Pull request has been modified.

@buffalojoec buffalojoec merged commit e988e6f into master Jan 11, 2024
33 checks passed
@buffalojoec buffalojoec deleted the 01-10-token_2022_repair_onchain_helper branch January 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque