Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename UnitQuaternion to QuatRotation #201

Merged
merged 7 commits into from
Nov 17, 2021

Conversation

hyrodium
Copy link
Collaborator

As discussed in #171 (comment), UnitQuaternion is confusing, and should be renamed to QuatRotation.

@hyrodium hyrodium requested a review from andyferris November 16, 2021 13:56
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #201 (671ad49) into master (2e02102) will not change coverage.
The diff coverage is 93.10%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files          14       14           
  Lines        1403     1403           
=======================================
  Hits         1217     1217           
  Misses        186      186           
Impacted Files Coverage Δ
src/mean.jl 0.00% <0.00%> (ø)
src/mrps.jl 35.37% <87.50%> (ø)
src/rodrigues_params.jl 98.66% <87.50%> (ø)
src/error_maps.jl 93.19% <88.23%> (ø)
src/unitquaternion.jl 96.20% <97.61%> (ø)
src/angleaxis_types.jl 94.05% <100.00%> (ø)
src/core_types.jl 90.44% <100.00%> (ø)
src/derivatives.jl 100.00% <100.00%> (ø)
src/principal_value.jl 100.00% <100.00%> (ø)
src/rotation_error.jl 82.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e02102...671ad49. Read the comment docs.

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

# Deprecate Quat => UnitQuaternion
Base.@deprecate_binding Quat UnitQuaternion true
# Deprecate Quat => QuatRotation
Base.@deprecate_binding Quat QuatRotation true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove this old deprecation.

Copy link
Collaborator Author

@hyrodium hyrodium Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove RodriguesVec and SPQuat too?

The old deprecations for RodriguesVec, SPQuat and Quat has been introduced in this commit (#116):
793d384#diff-0c3a3096ea8aa5548f7facdd7eaa649293a64f785376cca25e23f14d6af4301d

If we can remove the deprecation for Quat, then I think the others also can be removed.
The old type names were already deprecated before v1.0.0 release, so I thought it's okay to remove them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds fine.

@hyrodium hyrodium merged commit 1e70142 into JuliaGeometry:master Nov 17, 2021
@hyrodium hyrodium mentioned this pull request Nov 17, 2021
ferrolho added a commit to ferrolho/RigidBodyDynamics.jl that referenced this pull request Nov 30, 2021
ferrolho added a commit to ferrolho/RigidBodyDynamics.jl that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants