-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sdformats and urdfs adjacent to external meshes #13942
Comments
Note that this might have implications for #10531. It might mean that for things like |
Update from discussing this with Russ: In solving this issue, now that we've decided on a single If we want that repository to stand on its own (and that seems like a nice goal), then we should add one or more We'll need to iterate on this design a little bit. |
Done in RobotLocomotion/models#22.
Yes. Done in #18919. What remains here is just the boring work of copying the SDFormat files (not moving!) and deprecating their current |
#19986 proposes that Drake CI will run the linters. That means a PR to |
In order to close #11913, I'll add one more specific task here: the files at |
FYI I'm working on this now. Getting all of the model files in one place is pretty much a requirement for converting them to glTF without headaches. |
See https://drake.mit.edu/model_version_control.html for background.
We are storing models' meshes, textures, and other large files in https://github.com/RobotLocomotion/models, so that a
git clone
of Drake does not grow inordinately large. In the procedures for that, we say:The thought was that these small text files might change or fork frequently (e.g., to change collision models, or other contact properties), and so laundering those changes through an external repository would be cumbersome. Furthermore, within Drake we have CI that can validate that the files are well-formed, can be loaded by our parser, etc. If we stored the text files along with the meshes, we would need to modify those procedures.
On the other hand, it is also awkward to add new models, or preview the current models, with the files split between git repositories.
Relatedly, it's not unusual for us to inherit the models from a third-party repository, which means we must propagate the licensing information. Pushing it to two places is awkward, and having third-party code (e.g., urdf) committed into drake in the manipulation/models folder (instead of third_party) makes license sanity checking for distribution and release more awkward.
We should consider changing the policy, and moving the sdformat and urdf files into the external repository, in cases where they have large files associated with them.
Edited to add:
Remaining checklist:
The text was updated successfully, but these errors were encountered: