Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of all validator thread-pool sizes via CLI #105

Open
steviez opened this issue Mar 6, 2024 · 0 comments
Open

Allow configuration of all validator thread-pool sizes via CLI #105

steviez opened this issue Mar 6, 2024 · 0 comments
Assignees

Comments

@steviez
Copy link

steviez commented Mar 6, 2024

Problem

As mentioned in #35, agave-validator (previously solana-validator) spawns lots of thread pools / tokio runtimes. For the majority of these, the size of the pool/runtime is specified by a constant in code, or configured to scale with the number of cores on the machine.

Some of sizes were carefully chosen and may still be an appropriate amount. Other values might have been unintentionally set to scale with number of cores (this is the default behavior when the number of threads is not specifically set). Or, some values might have become "incorrect" as the workload of the cluster changes / refactors occur and shift where heavier operations occur.

In any case, being able to control these sizes could be a powerful knob to turn.

Proposed Solution

  • Add CLI flags + plumbing for thread pool size parameters
  • The addition of the CLI flags should NOT alter any thread pool sizes
  • The flags should probably be hidden, maybe forever. Or, if we make them public, they'll need a warning along the lines of "you should only be using this if you know what you're doing"
  • Finally, having the ability to configure all sizes should make the rayon-threadlimit crate obsolete, altho we may need to follow a proper deprecation sequence for that crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant